kaiyuan/chatgpt-on-wechat
1
0
Fork 0
mirror of https://github.com/zhayujie/chatgpt-on-wechat.git synced 2026-07-18 12:07:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(tools): make web SSRF protection opt-in, disabled by default

Browse Source
This commit is contained in:
zhayujie
2026-06-24 19:40:55 +08:00
parent 0c20c5c159
commit 915edbe145
3 changed files with 87 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
tests/test_security_ssrf_web_fetch.py
View File

@@ -74,12 +74,24 @@ def _fake_ok_response(body=b"<html><head><title>internal</title></head><body>sec
class TestWebFetchSSRF(unittest.TestCase):
"""web_fetch must refuse internal targets and never connect to them."""
"""web_fetch must refuse internal targets and never connect to them.
SSRF protection is opt-in (disabled by default), so these tests enable it
via the WEB_SECURITY_SSRF_PROTECTION env var for the duration of the test.
"""
def setUp(self):
self._prev_ssrf_env = os.environ.get("WEB_SECURITY_SSRF_PROTECTION")
os.environ["WEB_SECURITY_SSRF_PROTECTION"] = "true"
from agent.tools.web_fetch.web_fetch import WebFetch
self.tool = WebFetch()
def tearDown(self):
if self._prev_ssrf_env is None:
os.environ.pop("WEB_SECURITY_SSRF_PROTECTION", None)
else:
os.environ["WEB_SECURITY_SSRF_PROTECTION"] = self._prev_ssrf_env
# --- Literal internal IPs: rejected before any socket call ---
def test_loopback_literal_blocked(self):
@@ -184,5 +196,29 @@ class TestWebFetchSSRF(unittest.TestCase):
self.assertEqual(mock_get.call_args[0][0], "http://example.com/page")
class TestWebFetchSSRFDisabledByDefault(unittest.TestCase):
"""With protection disabled (default), local/internal targets are reachable."""
def setUp(self):
self._prev_ssrf_env = os.environ.get("WEB_SECURITY_SSRF_PROTECTION")
os.environ.pop("WEB_SECURITY_SSRF_PROTECTION", None)
from agent.tools.web_fetch.web_fetch import WebFetch
self.tool = WebFetch()
def tearDown(self):
if self._prev_ssrf_env is None:
os.environ.pop("WEB_SECURITY_SSRF_PROTECTION", None)
else:
os.environ["WEB_SECURITY_SSRF_PROTECTION"] = self._prev_ssrf_env
def test_loopback_allowed_when_disabled(self):
"""http://127.0.0.1/x must be fetched when protection is off (default)."""
with patch("socket.getaddrinfo", return_value=_gai("127.0.0.1")), \
patch("requests.get", return_value=_fake_ok_response()) as mock_get:
result = self.tool.execute({"url": "http://127.0.0.1:8080/local"})
self.assertEqual(result.status, "success")
mock_get.assert_called_once()
if __name__ == "__main__":
unittest.main()