From 7f8f690497fab4b9e0b37f14adf922d823347d6c Mon Sep 17 00:00:00 2001 From: zhayujie Date: Thu, 16 Jul 2026 14:56:23 +0800 Subject: [PATCH] refactor(tools): remove dead playwright-missing branches --- agent/tools/__init__.py | 12 +++--------- agent/tools/tool_manager.py | 27 +++------------------------ 2 files changed, 6 insertions(+), 33 deletions(-) diff --git a/agent/tools/__init__.py b/agent/tools/__init__.py index 1e508c0c..ec469174 100644 --- a/agent/tools/__init__.py +++ b/agent/tools/__init__.py @@ -90,20 +90,14 @@ FileSave = _optional_tools.get('FileSave') Terminal = _optional_tools.get('Terminal') -# BrowserTool (requires playwright) +# BrowserTool: playwright is soft-imported inside browser_service, so this +# import always succeeds even without playwright. Readiness (playwright pkg / +# system Chrome / downloaded Chromium) is checked at call time in BrowserTool. def _import_browser_tool(): from common.log import logger try: from agent.tools.browser.browser_tool import BrowserTool return BrowserTool - except ImportError as e: - logger.info( - f"[Tools] BrowserTool not loaded - missing dependency: {e}\n" - f" To enable browser tool, run:\n" - f" pip install playwright\n" - f" playwright install chromium" - ) - return None except Exception as e: logger.error(f"[Tools] BrowserTool failed to load: {e}") return None diff --git a/agent/tools/tool_manager.py b/agent/tools/tool_manager.py index e282a15e..ef3600f3 100644 --- a/agent/tools/tool_manager.py +++ b/agent/tools/tool_manager.py @@ -152,14 +152,7 @@ class ToolManager: except ImportError as e: # Handle missing dependencies with helpful messages error_msg = str(e) - if "playwright" in error_msg: - logger.warning( - f"[ToolManager] Browser tool not loaded - missing dependencies.\n" - f" To enable browser tool, run:\n" - f" pip install playwright\n" - f" playwright install chromium" - ) - elif "markdownify" in error_msg: + if "markdownify" in error_msg: logger.warning( f"[ToolManager] {cls.__name__} not loaded - missing markdownify.\n" f" Install with: pip install markdownify" @@ -222,14 +215,7 @@ class ToolManager: except ImportError as e: # Handle missing dependencies with helpful messages error_msg = str(e) - if "playwright" in error_msg: - logger.warning( - f"[ToolManager] Browser tool not loaded - missing dependencies.\n" - f" To enable browser tool, run:\n" - f" pip install playwright\n" - f" playwright install chromium" - ) - elif "markdownify" in error_msg: + if "markdownify" in error_msg: logger.warning( f"[ToolManager] {cls.__name__} not loaded - missing markdownify.\n" f" Install with: pip install markdownify" @@ -261,14 +247,7 @@ class ToolManager: # If there are missing tools, record warnings if missing_tools: for tool_name in missing_tools: - if tool_name == "browser": - logger.warning( - f"[ToolManager] Browser tool is configured but not loaded.\n" - f" To enable browser tool, run:\n" - f" pip install playwright\n" - f" playwright install chromium" - ) - elif tool_name == "google_search": + if tool_name == "google_search": logger.warning( f"[ToolManager] Google Search tool is configured but may need API key.\n" f" Get API key from: https://serper.dev\n"