fix: createdBy & updatedBy target option (#4109)

packages/plugins/@nocobase/plugin-collection-manager/src/server/__tests__/migrations/fix-created-by-field.test.ts

@@ -0,0 +1,164 @@
+import { MockServer } from '@nocobase/test';
+import { Database, MigrationContext } from '@nocobase/database';
+import { createApp } from '../index';
+import Migrator from '../../migrations/20240419182147-fix-created-by-field-target';
+
+describe('created by target', async () => {
+  let app: MockServer;
+  let db: Database;
+
+  beforeEach(async () => {
+    app = await createApp({});
+
+    db = app.db;
+  });
+
+  afterEach(async () => {
+    await app.destroy();
+  });
+
+  it('should fix target', async () => {
+    await db.getRepository('collections').create({
+      values: {
+        logging: true,
+        autoGenId: true,
+        createdAt: true,
+        createdBy: true,
+        updatedAt: true,
+        updatedBy: true,
+        fields: [
+          {
+            interface: 'integer',
+            name: 'parentId',
+            type: 'bigInt',
+            isForeignKey: true,
+            uiSchema: {
+              type: 'number',
+              title: '{{t("Parent ID")}}',
+              'x-component': 'InputNumber',
+              'x-read-pretty': true,
+            },
+            target: 'tests123',
+          },
+          {
+            interface: 'm2o',
+            type: 'belongsTo',
+            name: 'parent',
+            foreignKey: 'parentId',
+            treeParent: true,
+            onDelete: 'CASCADE',
+            uiSchema: {
+              title: '{{t("Parent")}}',
+              'x-component': 'AssociationField',
+              'x-component-props': { multiple: false, fieldNames: { label: 'id', value: 'id' } },
+            },
+            target: 'tests123',
+          },
+          {
+            interface: 'o2m',
+            type: 'hasMany',
+            name: 'children',
+            foreignKey: 'parentId',
+            treeChildren: true,
+            onDelete: 'CASCADE',
+            uiSchema: {
+              title: '{{t("Children")}}',
+              'x-component': 'AssociationField',
+              'x-component-props': { multiple: true, fieldNames: { label: 'id', value: 'id' } },
+            },
+            target: 'tests123',
+          },
+          {
+            name: 'id',
+            type: 'bigInt',
+            autoIncrement: true,
+            primaryKey: true,
+            allowNull: false,
+            uiSchema: {
+              type: 'number',
+              title: '{{t("ID")}}',
+              'x-component': 'InputNumber',
+              'x-read-pretty': true,
+            },
+            interface: 'integer',
+            target: 'tests123',
+          },
+          {
+            name: 'createdAt',
+            interface: 'createdAt',
+            type: 'date',
+            field: 'createdAt',
+            uiSchema: {
+              type: 'datetime',
+              title: '{{t("Created at")}}',
+              'x-component': 'DatePicker',
+              'x-component-props': {},
+              'x-read-pretty': true,
+            },
+            target: 'tests123',
+          },
+          {
+            name: 'createdBy',
+            interface: 'createdBy',
+            type: 'belongsTo',
+            target: 'tests123',
+            foreignKey: 'createdById',
+            uiSchema: {
+              type: 'object',
+              title: '{{t("Created by")}}',
+              'x-component': 'AssociationField',
+              'x-component-props': { fieldNames: { value: 'id', label: 'nickname' } },
+              'x-read-pretty': true,
+            },
+          },
+          {
+            type: 'date',
+            field: 'updatedAt',
+            name: 'updatedAt',
+            interface: 'updatedAt',
+            uiSchema: {
+              type: 'string',
+              title: '{{t("Last updated at")}}',
+              'x-component': 'DatePicker',
+              'x-component-props': {},
+              'x-read-pretty': true,
+            },
+            target: 'tests123',
+          },
+          {
+            type: 'belongsTo',
+            target: 'tests123',
+            foreignKey: 'updatedById',
+            name: 'updatedBy',
+            interface: 'updatedBy',
+            uiSchema: {
+              type: 'object',
+              title: '{{t("Last updated by")}}',
+              'x-component': 'AssociationField',
+              'x-component-props': { fieldNames: { value: 'id', label: 'nickname' } },
+              'x-read-pretty': true,
+            },
+          },
+        ],
+        name: 'tests123',
+        template: 'tree',
+        view: false,
+        tree: 'adjacencyList',
+        title: 'tests123',
+      },
+    });
+
+    const migration = new Migrator({ db } as MigrationContext);
+    migration.context.app = app;
+    await migration.up();
+
+    const field = await db.getRepository('fields').findOne({
+      filter: {
+        name: 'createdBy',
+        collectionName: 'tests123',
+      },
+    });
+
+    expect(field.get('target')).toBe('users');
+  });
+});

packages/plugins/@nocobase/plugin-collection-manager/src/server/migrations/20240419182147-fix-created-by-field-target.ts

@@ -0,0 +1,20 @@
+import { Migration } from '@nocobase/server';
+
+export default class extends Migration {
+  on = 'afterLoad'; // 'beforeLoad' or 'afterLoad'
+  appVersion = '<0.21.0-alpha.12';
+
+  async up() {
+    const fields = await this.db.getRepository('fields').find({
+      filter: {
+        name: ['createdBy', 'updatedBy'],
+        'options.target.$ne': 'users',
+      },
+    });
+
+    for (const field of fields) {
+      field.set('target', 'users');
+      await field.save();
+    }
+  }
+}