From 980f4d8919e8c9d67f55fb8c9945edc1eb538f85 Mon Sep 17 00:00:00 2001 From: Zeke Zhang <958414905@qq.com> Date: Tue, 11 Mar 2025 18:26:00 +0800 Subject: [PATCH] chore(e2e): make e2e more stable --- .../src/schema-settings/GeneralSchemaDesigner.tsx | 14 ++++++++++---- packages/core/client/src/schema-settings/styles.ts | 4 ---- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/packages/core/client/src/schema-settings/GeneralSchemaDesigner.tsx b/packages/core/client/src/schema-settings/GeneralSchemaDesigner.tsx index 7ba10563d5..cae1ab751b 100644 --- a/packages/core/client/src/schema-settings/GeneralSchemaDesigner.tsx +++ b/packages/core/client/src/schema-settings/GeneralSchemaDesigner.tsx @@ -310,8 +310,6 @@ const InternalSchemaToolbar: FC = React.memo((props) => { }, [schemaSettingsExists, schemaSettingsRender, settings]); const toolbarRef = useRef(null); - const hiddenClassName = process.env.__E2E__ ? 'hidden-e2e' : 'hidden'; - useEffect(() => { const toolbarElement = toolbarRef.current; let parentElement = toolbarElement?.parentElement; @@ -327,14 +325,22 @@ const InternalSchemaToolbar: FC = React.memo((props) => { function show() { if (toolbarElement) { - toolbarElement.classList.remove(hiddenClassName); + if (process.env.__E2E__) { + toolbarElement.style.display = 'block'; + } else { + toolbarElement.classList.remove('hidden'); + } props.onVisibleChange?.(true); } } function hide() { if (toolbarElement) { - toolbarElement.classList.add(hiddenClassName); + if (process.env.__E2E__) { + toolbarElement.style.display = 'none'; + } else { + toolbarElement.classList.add('hidden'); + } props.onVisibleChange?.(false); } } diff --git a/packages/core/client/src/schema-settings/styles.ts b/packages/core/client/src/schema-settings/styles.ts index 4439f000db..786821afed 100644 --- a/packages/core/client/src/schema-settings/styles.ts +++ b/packages/core/client/src/schema-settings/styles.ts @@ -31,10 +31,6 @@ export const useStyles = genStyleHook('nb-schema-toolbar', (token) => { pointerEvents: 'none', }, - '&.hidden-e2e': { - display: 'none', - }, - '.ant-space-item .anticon': { margin: 0, },