fix(database): fix trim option for string and text field (#6797)

packages/core/database/src/__tests__/fields/string-field.test.ts

@@ -119,4 +119,32 @@ describe('string field', () => {
       name: 'n1',
     });
   });
+
+  it('trim when value is null should be null', async () => {
+    const collection = db.collection({
+      name: 'tests',
+      fields: [{ type: 'string', name: 'name', trim: true }],
+    });
+    await db.sync();
+    const model = await collection.model.create({
+      name: null,
+    });
+    expect(model.toJSON()).toMatchObject({
+      name: null,
+    });
+  });
+
+  it('when value is number should be convert to string', async () => {
+    const collection = db.collection({
+      name: 'tests',
+      fields: [{ type: 'string', name: 'name', trim: true }],
+    });
+    await db.sync();
+    const model = await collection.model.create({
+      name: 123,
+    });
+    expect(model.toJSON()).toMatchObject({
+      name: '123',
+    });
+  });
 });

packages/core/database/src/__tests__/fields/text-field.test.ts

@@ -66,4 +66,32 @@ describe('text field', () => {
       name: 'n1',
     });
   });
+
+  it('trim when value is null should be null', async () => {
+    const collection = db.collection({
+      name: 'tests',
+      fields: [{ type: 'string', name: 'name', trim: true }],
+    });
+    await db.sync();
+    const model = await collection.model.create({
+      name: null,
+    });
+    expect(model.toJSON()).toMatchObject({
+      name: null,
+    });
+  });
+
+  it('when value is number should be convert to string', async () => {
+    const collection = db.collection({
+      name: 'tests',
+      fields: [{ type: 'string', name: 'name', trim: true }],
+    });
+    await db.sync();
+    const model = await collection.model.create({
+      name: 123,
+    });
+    expect(model.toJSON()).toMatchObject({
+      name: '123',
+    });
+  });
 });

packages/core/database/src/fields/string-field.ts

@@ -24,7 +24,13 @@ export class StringField extends Field {
 
     return {
       set(value) {
-        this.setDataValue(name, trim ? value?.trim() : value);
+        if (value == null) {
+          return value;
+        }
+        if (typeof value !== 'string') {
+          value = value.toString();
+        }
+        this.setDataValue(name, trim ? value.trim() : value);
       },
     };
   }

packages/core/database/src/fields/text-field.ts

@@ -29,7 +29,13 @@ export class TextField extends Field {
 
     return {
       set(value) {
-        this.setDataValue(name, trim ? value?.trim() : value);
+        if (value == null) {
+          return value;
+        }
+        if (typeof value !== 'string') {
+          value = value.toString();
+        }
+        this.setDataValue(name, trim ? value.trim() : value);
       },
     };
   }