fm453/nocobase
1
0
Fork 0
mirror of https://gitee.com/nocobase/nocobase.git synced 2025-07-01 18:52:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor: set remainsTheSame as the default value for field editing in bulk editing action (#5124)

Browse Source 
* refactor: bulk edit set remainsTheSame as default value

* fix: test
This commit is contained in:
Katherine 2024-08-27 14:54:02 +08:00 committed by GitHub
parent 3403e8d766
commit 2eaa0b8081
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/core/client/src/modules/blocks/data-blocks/form/__e2e__/form-edit/bulkEditForm.test.ts
View File

@ -26,7 +26,10 @@ test.describe('bulk edit form', () => {
// 2. 打开弹窗，显示出批量编辑表单
await page.getByLabel('action-Action-Bulk edit-').click();
// 默认为 "Changed to" 模式，此时应该显示字段是必填的
await page.getByLabel('block-item-BulkEditField-').click();
await page.getByRole('option', { name: 'Changed to' }).click();
// "Changed to" 模式，此时应该显示字段是必填的
await expect(page.getByLabel('block-item-BulkEditField-').getByText('*')).toBeVisible();
// 3. 输入值，点击提交
@ -45,7 +48,10 @@ test.describe('bulk edit form', () => {
// 1. 打开弹窗，显示出批量编辑表单
await page.getByLabel('action-Action-Bulk edit-').click();
// 默认为 "Changed to" 模式，此时应该显示字段是必填的
await page.getByLabel('block-item-BulkEditField-').click();
await page.getByRole('option', { name: 'Changed to' }).click();
// "Changed to" 模式，此时应该显示字段是必填的
await expect(page.getByLabel('block-item-BulkEditField-').getByText('*')).toBeVisible();
// 2. 切换为其它模式，此时应该不显示字段是必填的

2
packages/plugins/@nocobase/plugin-action-bulk-edit/src/client/component/BulkEditField.tsx
View File

@ -95,7 +95,7 @@ export const BulkEditField = (props: any) => {
const { t } = useTranslation();
const fieldSchema = useFieldSchema();
const field = useField<Field>();
const [type, setType] = useState<number>(BulkEditFormItemValueType.ChangedTo);
const [type, setType] = useState<number>(BulkEditFormItemValueType.RemainsTheSame);
const [value, setValue] = useState(null);
const { getField } = useCollection_deprecated();
const collectionField = getField(fieldSchema.name) || {};