Merge branch 'main' into next

packages/plugins/@nocobase/plugin-collection-tree/src/server/__tests__/issues.test.ts

@@ -0,0 +1,66 @@
+/**
+ * This file is part of the NocoBase (R) project.
+ * Copyright (c) 2020-2024 NocoBase Co., Ltd.
+ * Authors: NocoBase Team.
+ *
+ * This project is dual-licensed under AGPL-3.0 and NocoBase Commercial License.
+ * For more information, please refer to: https://www.nocobase.com/agreement.
+ */
+
+import { Database } from '@nocobase/database';
+import { MockServer, createMockServer } from '@nocobase/test';
+
+describe('issues', async () => {
+  let app: MockServer;
+  let db: Database;
+  beforeEach(async () => {
+    app = await createMockServer({
+      plugins: ['collection-tree'],
+    });
+    db = app.db;
+    db.collection({
+      name: 'tree',
+      tree: 'adjacency-list',
+      fields: [
+        {
+          type: 'string',
+          name: 'name',
+        },
+        {
+          type: 'belongsTo',
+          name: 'parent',
+          foreignKey: 'parentId',
+          treeParent: true,
+        },
+        {
+          type: 'hasMany',
+          name: 'children',
+          foreignKey: 'parentId',
+          treeChildren: true,
+        },
+      ],
+    });
+    await db.sync();
+  });
+
+  afterEach(async () => {
+    await db.clean({ drop: true });
+    await app.destroy();
+  });
+
+  it('should not set itself as parent', async () => {
+    expect.assertions(1);
+    const root = await db.getRepository('tree').create({
+      values: {
+        name: 'root',
+      },
+    });
+    try {
+      await root.update({
+        parentId: root.get('id'),
+      });
+    } catch (error) {
+      expect(error.message).toBe('Cannot set itself as the parent node');
+    }
+  });
+});

packages/plugins/@nocobase/plugin-collection-tree/src/server/plugin.ts

@@ -102,6 +102,13 @@ class PluginCollectionTreeServer extends Plugin {
               transaction: options.transaction,
             });
           });
+
+          this.db.on(`${collection.name}.beforeSave`, async (model: Model) => {
+            const tk = collection.filterTargetKey as string;
+            if (model.get(parentForeignKey) === model.get(tk)) {
+              throw new Error('Cannot set itself as the parent node');
+            }
+          });
         });
       }
     });